Claude review: drm/bridge: dw-hdmi-qp: Return -EOPNOTSUPP in HDMI audio functions

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/bridge: dw-hdmi-qp: Return -EOPNOTSUPP in HDMI audio functions
Author: Detlev Casanova <detlev.casanova@collabora.com>
Patches: 1
Reviewed: 2026-05-25T22:33:16.962963

---

This is a single-patch series that changes the error code returned by the `dw_hdmi_qp_audio_enable` and `dw_hdmi_qp_audio_prepare` callbacks from `-ENODEV` (and implicit success-when-not-ready) to `-EOPNOTSUPP` when `tmds_char_rate == 0` (i.e., HDMI is not connected).

The change is well-motivated and correct. The ASoC framework's `snd_soc_ret()` function (`sound/soc/soc-utils.c:18-42`) explicitly suppresses logging for `-EOPNOTSUPP` and `-ENOTSUPP`, while all other negative error codes (including the previous `-ENODEV`) produce `dev_err` messages. This means the old code was generating spurious error logs whenever audio operations were attempted while HDMI was disconnected — a normal and frequent runtime condition.

The semantic choice is also correct: `-EOPNOTSUPP` ("operation not supported") accurately describes a transient state where the hardware exists but clocks aren't enabled yet, whereas `-ENODEV` ("no such device") incorrectly suggests the hardware is absent.

**Verdict: Looks good. Suitable for merging.**

---
Generated by Claude Code Patch Reviewer