From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/loongson: mode_config.cursor_width should use hw_cursor_w
Date: Mon, 25 May 2026 22:20:19 +1000 [thread overview]
Message-ID: <review-overall-20260520015309.35088-1-yaolu@kylinos.cn> (raw)
In-Reply-To: <20260520015309.35088-1-yaolu@kylinos.cn>
Overall Series Review
Subject: drm/loongson: mode_config.cursor_width should use hw_cursor_w
Author: yaolu@kylinos.cn
Patches: 1
Reviewed: 2026-05-25T22:20:19.689476
---
This is a single-patch trivial bugfix for an obvious copy-paste error in the Loongson display controller driver. The `cursor_width` field was being initialized from `hw_cursor_h` (height) instead of `hw_cursor_w` (width). The fix is correct and straightforward.
In practice, the current hardware descriptions define `hw_cursor_w == hw_cursor_h` (32x32 for ls7a1000 and 64x64 for ls7a2000/ls2k2000), so this bug had no visible effect. Still, it's clearly wrong and worth fixing.
The Fixes tag correctly references the original commit that introduced the Loongson KMS driver. The patch is well-formed.
**Verdict: Looks good. No issues found.**
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-25 12:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 7:40 [PATH] drm/loongson: mode_config.cursor_width should use hw_cursor_w yaolu
2026-05-19 8:33 ` Markus Elfring
2026-05-20 1:53 ` [PATCH v2] " yaolu
2026-05-25 12:20 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260520015309.35088-1-yaolu@kylinos.cn \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox