From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/exec: drm_exec polishing
Date: Mon, 25 May 2026 21:59:34 +1000 [thread overview]
Message-ID: <review-overall-20260520101616.41284-1-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20260520101616.41284-1-thomas.hellstrom@linux.intel.com>
Overall Series Review
Subject: drm/exec: drm_exec polishing
Author: =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= <thomas.hellstrom@linux.intel.com>
Patches: 11
Reviewed: 2026-05-25T21:59:34.662912
---
This is a well-structured cleanup series that improves the `drm_exec` API by hiding internal implementation details from drivers, preparing the way for a future refactoring where `drm_exec` could be subclassed from a WW transaction utility. The four patches progressively tighten the API surface: removing the exposed loop index, cleaning up the retry macro, formalizing the retry-on-OOM pattern, and adding a ticket accessor.
The series is clean, appropriately scoped, and the v2 changes properly address reviewer feedback. No functional bugs found. A few minor observations below.
**Verdict: Series looks good to merge.**
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 11:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 10:16 [PATCH v2 0/4] drm/exec: drm_exec polishing Thomas Hellström
2026-05-20 10:16 ` [PATCH v2 1/4] drm/exec: Remove the index parameter from drm_exec_for_each_locked_obj[_reverse] Thomas Hellström
2026-05-20 11:32 ` Christian König
2026-05-25 11:59 ` Claude review: " Claude Code Review Bot
2026-05-20 10:16 ` [PATCH v2 2/4] drm/exec: Make the drm_exec_until_all_locked() macro more readable Thomas Hellström
2026-05-20 11:35 ` Christian König
2026-05-25 11:59 ` Claude review: " Claude Code Review Bot
2026-05-20 10:16 ` [PATCH v2 3/4] drm/exec, drm/xe: Avoid abusing the drm_exec retry pointer Thomas Hellström
2026-05-20 11:39 ` Christian König
2026-05-25 11:59 ` Claude review: " Claude Code Review Bot
2026-05-20 10:16 ` [PATCH v2 4/4] drm/exec, drm/xe, drm/amdgpu: Add an accessor for struct drm_exec::ticket Thomas Hellström
2026-05-20 11:42 ` Christian König
2026-05-25 11:59 ` Claude review: " Claude Code Review Bot
2026-05-20 11:34 ` [PATCH v2 0/4] drm/exec: drm_exec polishing Christian König
2026-05-21 11:45 ` Thomas Hellström
2026-05-25 11:59 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-31 9:20 [PATCH 0/5] " Thomas Hellström
2026-03-31 21:52 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260520101616.41284-1-thomas.hellstrom@linux.intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox