From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/exec, drm/xe: Avoid abusing the drm_exec retry pointer
Date: Mon, 25 May 2026 21:59:35 +1000 [thread overview]
Message-ID: <review-patch3-20260520101616.41284-4-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20260520101616.41284-4-thomas.hellstrom@linux.intel.com>
Patch Review
**Assessment: Good, one minor concern.**
This formalizes the xe driver's pattern of directly using `goto *__drm_exec_retry_ptr` for OOM retry by introducing `drm_exec_retry()`:
```c
#define drm_exec_retry(_exec) \
do { \
WARN_ON((_exec)->contended != DRM_EXEC_DUMMY); \
goto *__drm_exec_retry_ptr; \
} while (0)
```
The `WARN_ON` check is correct: `xe_validation_should_retry()` calls `drm_exec_fini()` + `drm_exec_init()` before returning true, so `contended == DRM_EXEC_DUMMY` at that point. Then the `goto` jumps back to the `drm_exec_until_all_locked` label, which calls `drm_exec_cleanup()`, which sees `DRM_EXEC_DUMMY` and calls `ww_acquire_init()` to properly initialize the ticket. The flow is safe.
**Minor concern:** `DRM_EXEC_DUMMY` is moved from `drm_exec.c` to `drm_exec.h`, exposing an implementation detail in the public header. The "internal use only" comment mitigates this, but drivers could start relying on it. An alternative would be to add a `drm_exec_is_newly_initialized()` inline helper that hides the constant, but since the `goto` must remain in a macro anyway, this is acceptable as-is. Worth mentioning explicitly in the commit message that this is an intentional trade-off.
The xe_validation.h change is clean:
```c
- goto *__drm_exec_retry_ptr;
+ drm_exec_retry((_ctx)->exec);
```
And the comment update in xe_validation.c correctly narrows the scope of the "abuses" comment:
```c
- * This abuses both drm_exec and ww_mutex internals and should be
+ * This abuses ww_mutex internals and should be
```
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 11:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 10:16 [PATCH v2 0/4] drm/exec: drm_exec polishing Thomas Hellström
2026-05-20 10:16 ` [PATCH v2 1/4] drm/exec: Remove the index parameter from drm_exec_for_each_locked_obj[_reverse] Thomas Hellström
2026-05-20 11:32 ` Christian König
2026-05-25 11:59 ` Claude review: " Claude Code Review Bot
2026-05-20 10:16 ` [PATCH v2 2/4] drm/exec: Make the drm_exec_until_all_locked() macro more readable Thomas Hellström
2026-05-20 11:35 ` Christian König
2026-05-25 11:59 ` Claude review: " Claude Code Review Bot
2026-05-20 10:16 ` [PATCH v2 3/4] drm/exec, drm/xe: Avoid abusing the drm_exec retry pointer Thomas Hellström
2026-05-20 11:39 ` Christian König
2026-05-25 11:59 ` Claude Code Review Bot [this message]
2026-05-20 10:16 ` [PATCH v2 4/4] drm/exec, drm/xe, drm/amdgpu: Add an accessor for struct drm_exec::ticket Thomas Hellström
2026-05-20 11:42 ` Christian König
2026-05-25 11:59 ` Claude review: " Claude Code Review Bot
2026-05-20 11:34 ` [PATCH v2 0/4] drm/exec: drm_exec polishing Christian König
2026-05-21 11:45 ` Thomas Hellström
2026-05-25 11:59 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-31 9:20 [PATCH 0/5] " Thomas Hellström
2026-03-31 9:20 ` [PATCH 4/5] drm/exec, drm/xe: Avoid abusing the drm_exec retry pointer Thomas Hellström
2026-03-31 21:52 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260520101616.41284-4-thomas.hellstrom@linux.intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox