public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdgpu: fix recursive ww_mutex in devcoredump IB dump
Date: Mon, 25 May 2026 19:53:47 +1000	[thread overview]
Message-ID: <review-overall-20260520151741.50575-1-mikhail.v.gavrilov@gmail.com> (raw)
In-Reply-To: <20260520151741.50575-1-mikhail.v.gavrilov@gmail.com>

Overall Series Review

Subject: drm/amdgpu: fix recursive ww_mutex in devcoredump IB dump
Author: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
Patches: 21
Reviewed: 2026-05-25T19:53:47.734865

---

This mbox contains a patch series evolving across 5 versions (v1 → v5), fixing a real lockdep recursive locking splat and potential self-deadlock in the amdgpu devcoredump IB dump path. The latest version (v5) is a well-structured 2-patch series that converts `amdgpu_vm_lock_by_pasid()` to use `drm_exec` (patch 1) and then uses that to lock all BOs in one ww ticket (patch 2), as suggested by Christian König.

**The approach is correct and well-motivated.** The commit messages are thorough, the split is logical, and patch 1/2 already has Christian's Reviewed-by. The series also fixes a pre-existing BO refcount leak on the reserve-failure path.

**One correctness bug exists in v5 2/2:** the variable `r` is not initialized before the `drm_exec_until_all_locked` inner for-loop, which means a stale value could incorrectly break out of the locking loop when all IB mappings are NULL. This needs a fix before merging.

**Review of only the v5 patches follows** (v1–v4 are superseded).

---

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-05-25  9:53 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29 14:37 [PATCH] drm/amdgpu: fix recursive ww_mutex acquire in amdgpu_devcoredump_format Mikhail Gavrilov
2026-05-05  1:32 ` Claude review: " Claude Code Review Bot
2026-05-05  1:32 ` Claude Code Review Bot
2026-05-19 13:05 ` [PATCH] " Mikhail Gavrilov
2026-05-19 13:47   ` Christian König
2026-05-19 16:15 ` [PATCH v2] " Mikhail Gavrilov
2026-05-20  7:08   ` Christian König
2026-05-20  8:07     ` Mikhail Gavrilov
2026-05-20 11:01       ` Christian König
2026-05-20 15:17 ` [PATCH v3 0/2] drm/amdgpu: fix recursive ww_mutex in devcoredump IB dump Mikhail Gavrilov
2026-05-20 15:17   ` [PATCH v3 1/2] drm/amdgpu: convert amdgpu_vm_lock_by_pasid() to drm_exec Mikhail Gavrilov
2026-05-21  8:31     ` Christian König
2026-05-20 15:17   ` [PATCH v3 2/2] drm/amdgpu: fix recursive ww_mutex acquire in amdgpu_devcoredump_format Mikhail Gavrilov
2026-05-21  9:45     ` kernel test robot
2026-05-21 10:43   ` [PATCH v4 0/2] drm/amdgpu: fix recursive ww_mutex in devcoredump IB dump Mikhail Gavrilov
2026-05-21 10:43     ` [PATCH v4 1/2] drm/amdgpu: convert amdgpu_vm_lock_by_pasid() to drm_exec Mikhail Gavrilov
2026-05-21 12:39       ` Christian König
2026-05-21 10:43     ` [PATCH v4 2/2] drm/amdgpu: fix recursive ww_mutex acquire in amdgpu_devcoredump_format Mikhail Gavrilov
2026-05-21 15:08     ` [PATCH v5 0/2] drm/amdgpu: fix recursive ww_mutex in devcoredump IB dump Mikhail Gavrilov
2026-05-21 15:08       ` [PATCH v5 1/2] drm/amdgpu: convert amdgpu_vm_lock_by_pasid() to drm_exec Mikhail Gavrilov
2026-05-21 15:08       ` [PATCH v5 2/2] drm/amdgpu: fix recursive ww_mutex acquire in amdgpu_devcoredump_format Mikhail Gavrilov
2026-05-22  8:08         ` Christian König
2026-05-22  8:31           ` Mikhail Gavrilov
2026-05-25  9:53   ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260520151741.50575-1-mikhail.v.gavrilov@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox