[PATCH] drm: panel-orientation-quirks: Add quirk for Chuwi Minibook X

[PATCH] drm: panel-orientation-quirks: Add quirk for Chuwi Minibook X

[Vladislav Leonov]

This adds a DMI orientation quirk for the Chuwi Minibook X notebook.

Signed-off-by: Vladislav Leonov <vlad@zlab.su>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 3a218fb592ce..d185bf061385 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -283,6 +283,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Hi10 pro tablet"),
 		},
 		.driver_data = (void *)&lcd1200x1920_rightside_up,
+	}, {	/* Chuwi Minibook X */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "CHUWI Innovation And Technology(ShenZhen)co.,Ltd"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "MiniBook X"),
+		},
+		.driver_data = (void *)&lcd1200x1920_rightside_up,
 	}, {	/* Dynabook K50 */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dynabook Inc."),
-- 
2.47.3

Claude review: drm: panel-orientation-quirks: Add quirk for Chuwi Minibook X

[Claude Code Review Bot]

Overall Series Review

Subject: drm: panel-orientation-quirks: Add quirk for Chuwi Minibook X
Author: Vladislav Leonov <vlad@zlab.su>
Patches: 1
Reviewed: 2026-05-25T20:50:20.653831

---

This is a single-patch series that adds a DMI panel orientation quirk for the Chuwi Minibook X. The patch is straightforward and follows the established pattern used by other entries in `drm_panel_orientation_quirks.c`. The insertion point is correctly placed alphabetically (after the existing Chuwi Hi10 Pro entry, before Dynabook). The code compiles trivially as it's purely a data table addition.

**Minor concerns:**

1. The commit message is quite terse — it doesn't mention what the actual orientation problem is (i.e., that the panel is natively rotated and needs a right-side-up correction). A sentence describing the symptom ("The panel is mounted in portrait mode and needs 90° rotation") would be helpful for future readers of git log.

2. The resolution (1200x1920) should be confirmed. The Chuwi Minibook X has had multiple hardware revisions — some with 1920x1200 panels (10.51") and some with 2560x1600 (N100/N150 12.6" models). If the submitter tested on a 2560x1600 model, using `lcd1200x1920_rightside_up` would be wrong because the width/height check in the quirk lookup would not match. However, there is a well-known 10.51" N100 model with a 1200x1920 panel, so this is likely correct for that specific SKU.

3. No `Tested-by:` tag is present, though it is implied by the `Signed-off-by:` from the submitter. Not a blocker but nice to have for hardware quirks.

**Verdict:** The patch looks correct in form and follows all existing conventions. The only real risk is whether the resolution matches the actual hardware the submitter tested on. If the maintainer is satisfied that this was tested on the 1200x1920 variant, it's ready to merge.

---

---
Generated by Claude Code Patch Reviewer

Claude review: drm: panel-orientation-quirks: Add quirk for Chuwi Minibook X

[Claude Code Review Bot]

Patch Review

**Correctness:**

The new entry follows the exact same pattern as the adjacent Chuwi Hi10 Pro entry and dozens of others in this file:

```c
	}, {	/* Chuwi Minibook X */
		.matches = {
		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "CHUWI Innovation And Technology(ShenZhen)co.,Ltd"),
		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "MiniBook X"),
		},
		.driver_data = (void *)&lcd1200x1920_rightside_up,
```

- Uses `DMI_EXACT_MATCH` for both vendor and product name — appropriate and consistent with other entries.
- The vendor string `"CHUWI Innovation And Technology(ShenZhen)co.,Ltd"` is specific enough to avoid false matches.
- References `lcd1200x1920_rightside_up` (1200x1920, `DRM_MODE_PANEL_ORIENTATION_RIGHT_UP`) which is defined at line 139 of the file.

**Ordering:** Correctly inserted between the Chuwi Hi10 Pro block (line 280) and the Dynabook K50 block (line 292), maintaining alphabetical order by vendor/product.

**Indentation:** The `DMI_EXACT_MATCH` lines use 2-space indent inside `.matches`, matching the style of the adjacent Chuwi Hi10 Pro entry (lines 282-283). This is consistent.

**Potential issue — resolution mismatch for newer SKUs:** The Chuwi Minibook X product line includes both 10.51" (1200x1920) and 12.6" (1600x2560) variants. If both report `"MiniBook X"` as the DMI product name, the quirk would only fire on the 1200x1920 variant (because `drm_dmi_panel_orientation_data` checks width/height). The 12.6" model would silently not match, which is the correct safe behavior — but it means a second entry might be needed later if that model also has a rotated panel. This is not a bug, just a note.

**Suggestion for the commit message:** Consider expanding to mention the panel orientation symptom, e.g.: "The panel is natively mounted in portrait mode and needs a right-side-up rotation quirk."

**Overall:** No bugs. Acceptable as-is.

---
Generated by Claude Code Patch Reviewer