From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: perf: complete perf_allow_* trio and use in drm/xe
Date: Mon, 25 May 2026 21:03:40 +1000 [thread overview]
Message-ID: <review-overall-20260521024904.331912-1-jhubbard@nvidia.com> (raw)
In-Reply-To: <20260521024904.331912-1-jhubbard@nvidia.com>
Overall Series Review
Subject: perf: complete perf_allow_* trio and use in drm/xe
Author: John Hubbard <jhubbard@nvidia.com>
Patches: 3
Reviewed: 2026-05-25T21:03:40.409223
---
This is a clean, well-motivated 2-patch series from John Hubbard. Patch 1 promotes `perf_allow_cpu()` and `perf_allow_tracepoint()` from static inlines in `<linux/perf_event.h>` to out-of-line `EXPORT_SYMBOL_GPL` functions in `kernel/events/core.c`, following the existing pattern of `perf_allow_kernel()`. Patch 2 uses the newly-exported `perf_allow_cpu()` in drm/xe to replace open-coded permission checks, aligning xe observation with the system-wide perf security policy.
The series is logically structured, the commit messages are excellent, and the code transformations are straightforward. The behavioral change in patch 2 is intentional and clearly documented: xe observation now respects `kernel.perf_event_paranoid` and the LSM `security_perf_event_open()` hook, rather than doing a simple `perfmon_capable()` check.
There is one potential build issue worth flagging and one minor semantic concern. Overall this looks good to merge.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-25 11:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 2:49 [PATCH 0/2] perf: complete perf_allow_* trio and use in drm/xe John Hubbard
2026-05-21 2:49 ` [PATCH 1/2] perf/core: out-of-line and export perf_allow_cpu/tracepoint() John Hubbard
2026-05-25 11:03 ` Claude review: " Claude Code Review Bot
2026-05-21 2:49 ` [PATCH 2/2] drm/xe: gate observation streams with perf_allow_cpu() John Hubbard
2026-05-25 11:03 ` Claude review: " Claude Code Review Bot
2026-05-25 11:03 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260521024904.331912-1-jhubbard@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox