Claude review: drm/bridge: Implement generic USB Type-C DP HPD bridge

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/bridge: Implement generic USB Type-C DP HPD bridge
Author: Chaoyi Chen <kernel@airkyi.com>
Patches: 7
Reviewed: 2026-05-25T21:00:52.011314

---

This series implements a generic USB Type-C DP HPD bridge infrastructure and refactors the Rockchip CDN-DP controller to support multiple bridge/PHY port selection without depending on extcon. The design goal is sound: decouple DP hotplug detection from specific USB-C controller drivers, and allow the CDN-DP controller to work with either of the two combo PHYs on RK3399.

The series has already collected Reviewed-by tags from Heikki Krogerus, Neil Armstrong, Luca Ceresoli, and Heiko Stuebner. The architecture is reasonable, but there are several correctness issues, most notably an **uninitialized variable bug** in patch 5 that could cause a kernel crash, and some logic concerns around the multi-bridge HPD/EDID switching path.

**Key concerns:**
1. Patch 5: `prev_port` used uninitialized — potential NULL-pointer dereference or use of garbage pointer
2. Patch 5: `cdn_dp_switch_port` sets `dp->active = true` but is called from EDID read context, which could leave stale state
3. Patch 5: `cdn_dp_connected_port` changes semantics — the old non-`next_bridge_valid` path now falls through to the `next_bridge_valid` block
4. Patch 1: No error handling for `drm_dp_hpd_bridge_register` failure in bus notifier
5. Patch 4: Condition change in `cdn_dp_probe` may inadvertently filter out valid port configurations

---

---
Generated by Claude Code Patch Reviewer