From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: phy: rockchip: phy-rockchip-typec: Add DRM AUX bridge
Date: Mon, 25 May 2026 21:00:52 +1000 [thread overview]
Message-ID: <review-patch3-20260521032854.103-4-kernel@airkyi.com> (raw)
In-Reply-To: <20260521032854.103-4-kernel@airkyi.com>
Patch Review
Straightforward integration of the aux bridge into the Rockchip Type-C PHY driver.
**Issue: Error check ordering**
```c
if (of_node_name_eq(child_np, "dp-port")) {
phy = devm_phy_create(dev, child_np, &rockchip_dp_phy_ops);
ret = drm_aux_bridge_register_from_node(dev, child_np);
} else if ...
if (ret) {
pm_runtime_disable(dev);
of_node_put(child_np);
return ret;
}
if (IS_ERR(phy)) {
```
If `devm_phy_create()` succeeds but `drm_aux_bridge_register_from_node()` returns `-EPROBE_DEFER`, we return the error but the PHY remains registered (via devm). This is fine because devm will clean it up, but it means the order of checking `ret` before `IS_ERR(phy)` could mask a PHY creation failure. If `devm_phy_create` fails AND `drm_aux_bridge_register_from_node` fails, the bridge error is returned while the PHY error is lost. Consider checking `IS_ERR(phy)` first.
**Kconfig dependency:**
```
depends on DRM || DRM=n
select DRM_AUX_BRIDGE if DRM_BRIDGE
```
This is a reasonable conditional select pattern for optional DRM dependencies.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 11:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 3:28 [PATCH 0/5] drm/bridge: Implement generic USB Type-C DP HPD bridge Chaoyi Chen
2026-05-21 3:28 ` [PATCH 1/5] " Chaoyi Chen
2026-05-25 11:00 ` Claude review: " Claude Code Review Bot
2026-05-21 3:28 ` [PATCH 2/5] drm/bridge: aux: Add drm_aux_bridge_register_from_node() Chaoyi Chen
2026-05-25 11:00 ` Claude review: " Claude Code Review Bot
2026-05-21 3:28 ` [PATCH 3/5] phy: rockchip: phy-rockchip-typec: Add DRM AUX bridge Chaoyi Chen
2026-05-21 9:06 ` Heiko Stuebner
2026-05-25 11:00 ` Claude Code Review Bot [this message]
2026-05-21 3:28 ` [PATCH 4/5] drm/rockchip: cdn-dp: Support handle lane info without extcon Chaoyi Chen
2026-05-25 11:00 ` Claude review: " Claude Code Review Bot
2026-05-21 3:28 ` [PATCH 5/5] drm/rockchip: cdn-dp: Add multiple bridges to support PHY port selection Chaoyi Chen
2026-05-25 11:00 ` Claude review: " Claude Code Review Bot
2026-05-25 11:00 ` Claude review: drm/bridge: Implement generic USB Type-C DP HPD bridge Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-04 9:41 [PATCH v15 0/9] Add Type-C DP support for RK3399 EVB IND board Chaoyi Chen
2026-03-04 9:41 ` [PATCH v15 5/9] phy: rockchip: phy-rockchip-typec: Add DRM AUX bridge Chaoyi Chen
2026-03-05 3:38 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260521032854.103-4-kernel@airkyi.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox