Claude review: drm/i915: use 'depends on' with visible DEBUG_OBJECTS for DRM_I915_DEBUG and DRM_I915_SW_FENCE_DEBUG_OBJECTS

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/i915: use 'depends on' with visible DEBUG_OBJECTS for DRM_I915_DEBUG and DRM_I915_SW_FENCE_DEBUG_OBJECTS
Author: Julian Braha <julianbraha@gmail.com>
Patches: 1
Reviewed: 2026-05-25T20:01:46.137153

---

This is a single-patch series that changes how `DRM_I915_SW_FENCE_DEBUG_OBJECTS` references `DEBUG_OBJECTS` — switching from `select` to `depends on` — and adds a new `depends on DEBUG_OBJECTS` to `DRM_I915_DEBUG`. The stated goal is to fix a Kconfig "select-visible" anti-pattern detected by the Kconfirm static analysis tool.

The intent is reasonable: `select`-ing a user-visible symbol is indeed a Kconfig anti-pattern because it can silently force-enable options without satisfying their dependencies. However, **this patch introduces a functional regression** by making it harder to enable `DRM_I915_DEBUG` — a key developer debugging option — without manually hunting down and enabling `DEBUG_OBJECTS` (and its transitive deps like `DEBUG_KERNEL`) first.

The patch also has a structural problem in how it resolves the dependency chain.

---
Generated by Claude Code Patch Reviewer