From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: bus: mhi: Fix broken runtime PM design
Date: Mon, 25 May 2026 19:03:03 +1000 [thread overview]
Message-ID: <review-overall-20260522-mhi_runtimepm-v2-0-fbebf41a82bb@oss.qualcomm.com> (raw)
In-Reply-To: <20260522-mhi_runtimepm-v2-0-fbebf41a82bb@oss.qualcomm.com>
Overall Series Review
Subject: bus: mhi: Fix broken runtime PM design
Author: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
Patches: 8
Reviewed: 2026-05-25T19:03:03.597455
---
This series attempts to fix a fundamental design flaw in MHI runtime PM by replacing controller-level callback indirection (`runtime_get/put`) with standard `pm_runtime_*` APIs, and pushing PM ownership from the MHI core down to client drivers via proper parent-child PM hierarchy. The design direction is correct and well-motivated.
However, the series has several issues ranging from inconsistent API usage across client drivers (patches 3-5) to a **dev_wake counter imbalance bug in patch 6** that could cause incorrect power state tracking. The inconsistent error handling between `mhi_wwan_ctrl` (which uses `pm_runtime_resume_and_get` and conditional cleanup) and `mhi_wwan_mbim` (which uses raw `pm_runtime_get` and unconditional cleanup) within the *same patch* suggests insufficient cross-checking.
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-25 9:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 10:00 [PATCH v2 0/6] bus: mhi: Fix broken runtime PM design Krishna Chaitanya Chundru
2026-05-22 10:00 ` [PATCH v2 1/6] bus: mhi: Replace controller runtime_get/put callbacks with direct PM runtime APIs Krishna Chaitanya Chundru
2026-05-25 9:03 ` Claude review: " Claude Code Review Bot
2026-05-22 10:00 ` [PATCH v2 2/6] bus: mhi: Drop controller runtime PM callback indirection Krishna Chaitanya Chundru
2026-05-25 9:03 ` Claude review: " Claude Code Review Bot
2026-05-22 10:00 ` [PATCH v2 3/6] net: mhi_net: Hold runtime PM during active data path operations Krishna Chaitanya Chundru
2026-05-22 20:09 ` Loic Poulain
2026-05-25 9:03 ` Claude review: " Claude Code Review Bot
2026-05-22 10:00 ` [PATCH v2 4/6] net: qrtr: " Krishna Chaitanya Chundru
2026-05-25 9:03 ` Claude review: " Claude Code Review Bot
2026-05-22 10:00 ` [PATCH v2 5/6] net: wwan: " Krishna Chaitanya Chundru
2026-05-25 9:03 ` Claude review: " Claude Code Review Bot
2026-05-22 10:00 ` [PATCH v2 6/6] bus: mhi: host: Fix runtime PM ownership between clients and controller Krishna Chaitanya Chundru
2026-05-25 9:03 ` Claude review: " Claude Code Review Bot
2026-05-25 9:03 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260522-mhi_runtimepm-v2-0-fbebf41a82bb@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox