From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vmwgfx: Check whether CRTC is active when updating planes
Date: Mon, 25 May 2026 18:10:44 +1000 [thread overview]
Message-ID: <review-overall-20260522195303.797091-1-ian.forbes@broadcom.com> (raw)
In-Reply-To: <20260522195303.797091-1-ian.forbes@broadcom.com>
Overall Series Review
Subject: drm/vmwgfx: Check whether CRTC is active when updating planes
Author: Ian Forbes <ian.forbes@broadcom.com>
Patches: 1
Reviewed: 2026-05-25T18:10:44.733742
---
This is a single-patch fix for the vmwgfx STDU (Screen Target Display Unit) primary plane atomic update path. The patch addresses two issues:
1. **Missing CRTC active check**: The `atomic_update` callback was executing the full surface bind/update path even when the CRTC was not active, which the IGT `kms_universal_plane` test exposed — the screen target is not defined in that state, triggering an error.
2. **NULL dereference in else branch**: The old code accessed `old_state->crtc` in the else branch without a NULL check, which is unsafe since the else branch is entered when `new_state->crtc` is NULL, and `old_state->crtc` is not guaranteed to be non-NULL either.
The fix is correct, minimal, and well-targeted. Both issues are real bugs.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 8:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 19:53 [PATCH] drm/vmwgfx: Check whether CRTC is active when updating planes Ian Forbes
2026-05-25 8:10 ` Claude Code Review Bot [this message]
2026-05-25 8:10 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260522195303.797091-1-ian.forbes@broadcom.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox