From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: set SB_I_NOEXEC and SB_I_NODEV on the pseudo filesystem
Date: Mon, 25 May 2026 18:08:03 +1000 [thread overview]
Message-ID: <review-overall-20260523011117.121390-1-jhubbard@nvidia.com> (raw)
In-Reply-To: <20260523011117.121390-1-jhubbard@nvidia.com>
Overall Series Review
Subject: dma-buf: set SB_I_NOEXEC and SB_I_NODEV on the pseudo filesystem
Author: John Hubbard <jhubbard@nvidia.com>
Patches: 1
Reviewed: 2026-05-25T18:08:03.836365
---
This is a single, well-motivated bugfix patch. The dma-buf pseudo filesystem uses `alloc_anon_inode()` to create `S_ANON_INODE` inodes, but never declared `SB_I_NOEXEC` on its superblock. Since commit `1e7ab6f67824` added a `VFS_WARN_ON_ONCE` assertion in `path_noexec()` (fs/exec.c:118-119) that fires when an anonymous inode's superblock lacks `SB_I_NOEXEC`, any `mmap()` on a dma-buf fd now triggers a warning on `CONFIG_DEBUG_VFS=y` kernels.
The fix is correct, minimal, and follows established precedent. The `Cc: stable` tag is appropriate since this is a regression fix for a warning introduced in 6.17.
**Verdict: Looks good to merge.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 8:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 1:11 [PATCH v2] dma-buf: set SB_I_NOEXEC and SB_I_NODEV on the pseudo filesystem John Hubbard
2026-05-25 8:08 ` Claude Code Review Bot [this message]
2026-05-25 8:08 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260523011117.121390-1-jhubbard@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox