From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/radeon/radeon_connectors: use struct drm_edid
Date: Mon, 25 May 2026 17:37:44 +1000 [thread overview]
Message-ID: <review-overall-20260523142748.50034-1-jpeisach@ubuntu.com> (raw)
In-Reply-To: <20260523142748.50034-1-jpeisach@ubuntu.com>
Overall Series Review
Subject: drm/radeon/radeon_connectors: use struct drm_edid
Author: Joshua Peisach <jpeisach@ubuntu.com>
Patches: 4
Reviewed: 2026-05-25T17:37:44.687299
---
This is a 2-patch series converting the radeon connector code from the deprecated `struct edid` / `drm_get_edid()` / `drm_connector_update_edid_property()` API to the newer `struct drm_edid` / `drm_edid_read_ddc()` / `drm_edid_connector_update()` API. This mirrors an equivalent conversion already done for amdgpu.
The overall approach is correct and the API migration is sound. The new functions exist in the kernel tree with the expected signatures. The series is logically split: patch 1 does the type/API conversion, patch 2 inlines and removes the now-trivial `radeon_connector_free_edid` helper. However, there are issues with the ordering of patches in the mbox (patch 2/2 appears before patch 1/2), and there are a few correctness concerns worth raising.
**Verdict: Needs minor revision** — the series is on the right track but has a few issues to address.
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-25 7:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 14:27 [PATCH NEXT 0/2] drm/radeon/radeon_connectors: use struct drm_edid Joshua Peisach
2026-05-23 14:27 ` [PATCH NEXT 1/2] drm/radeon/radeon_connectors: use struct drm_edid instead of struct edid Joshua Peisach
2026-05-23 14:39 ` Joshua Peisach
2026-05-25 7:37 ` Claude review: " Claude Code Review Bot
2026-05-23 14:27 ` [PATCH NEXT 2/2] drm/radeon/radeon_connectors: remove radeon_connector_free_edid Joshua Peisach
2026-05-25 7:37 ` Claude review: " Claude Code Review Bot
2026-05-25 7:37 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260523142748.50034-1-jpeisach@ubuntu.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox