From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/dp: Drop the HPD state machine
Date: Mon, 25 May 2026 17:13:06 +1000 [thread overview]
Message-ID: <review-overall-20260524-hpd-refactor-v6-0-cf3ab488dd7b@oss.qualcomm.com> (raw)
In-Reply-To: <20260524-hpd-refactor-v6-0-cf3ab488dd7b@oss.qualcomm.com>
Overall Series Review
Subject: drm/msm/dp: Drop the HPD state machine
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patches: 12
Reviewed: 2026-05-25T17:13:06.974075
---
This is a 10-patch series from Dmitry Baryshkov (with Jessica Zhang co-authoring several patches) that removes the HPD state machine from the MSM DP driver. The series is well-structured as incremental refactoring steps: first fixing register/enum bugs, then progressively dismantling the event queue and state machine, and finally introducing a cleaner model with a `plugged` boolean and direct `drm_bridge_hpd_notify()` calls.
The overall direction is sound - the old state machine was a known source of state desync bugs with the DRM framework. The series has good test coverage (Val Packett on x1e80100 Dell, Yongxing Mou on QCS8300).
However, I found several issues ranging from minor typos to a PM refcount leak and a logic bug in `get_modes`. The most significant concerns are in patches 7 and 9.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 7:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-24 10:33 [PATCH v6 00/10] drm/msm/dp: Drop the HPD state machine Dmitry Baryshkov
2026-05-24 10:33 ` [PATCH v6 01/10] drm/msm/dp: fix HPD state status bit shift value Dmitry Baryshkov
2026-05-25 7:13 ` Claude review: " Claude Code Review Bot
2026-05-24 10:33 ` [PATCH v6 02/10] drm/msm/dp: Fix the ISR_* enum values Dmitry Baryshkov
2026-05-25 7:13 ` Claude review: " Claude Code Review Bot
2026-05-24 10:33 ` [PATCH v6 03/10] drm/msm/dp: Read DPCD and sink count in bridge detect() Dmitry Baryshkov
2026-05-25 7:13 ` Claude review: " Claude Code Review Bot
2026-05-24 10:33 ` [PATCH v6 04/10] drm/msm/dp: Move link training to atomic_enable() Dmitry Baryshkov
2026-05-25 7:13 ` Claude review: " Claude Code Review Bot
2026-05-24 10:33 ` [PATCH v6 05/10] drm/msm/dp: Drop EV_USER_NOTIFICATION Dmitry Baryshkov
2026-05-25 7:13 ` Claude review: " Claude Code Review Bot
2026-05-24 10:33 ` [PATCH v6 06/10] drm/msm/dp: drop event data Dmitry Baryshkov
2026-05-25 7:13 ` Claude review: " Claude Code Review Bot
2026-05-24 10:33 ` [PATCH v6 07/10] drm/msm/dp: rework HPD handling Dmitry Baryshkov
2026-05-25 7:13 ` Claude review: " Claude Code Review Bot
2026-05-24 10:33 ` [PATCH v6 08/10] drm/msm/dp: Add sink_count to debug logs Dmitry Baryshkov
2026-05-25 7:13 ` Claude review: " Claude Code Review Bot
2026-05-24 10:33 ` [PATCH v6 09/10] drm/msm/dp: turn link_ready into plugged Dmitry Baryshkov
2026-05-25 7:13 ` Claude review: " Claude Code Review Bot
2026-05-24 10:33 ` [PATCH v6 10/10] drm/msm/dp: clear EDID on display unplug Dmitry Baryshkov
2026-05-25 7:13 ` Claude review: " Claude Code Review Bot
2026-05-24 21:32 ` [PATCH v6 00/10] drm/msm/dp: Drop the HPD state machine Val Packett
2026-05-25 7:13 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-14 1:09 [PATCH v5 " Dmitry Baryshkov
2026-03-16 2:12 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260524-hpd-refactor-v6-0-cf3ab488dd7b@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox