From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Add support for Renesas RZ/G3L LVDS encoder
Date: Mon, 25 May 2026 16:56:33 +1000 [thread overview]
Message-ID: <review-overall-20260524194457.479681-1-biju.das.jz@bp.renesas.com> (raw)
In-Reply-To: <20260524194457.479681-1-biju.das.jz@bp.renesas.com>
Overall Series Review
Subject: Add support for Renesas RZ/G3L LVDS encoder
Author: Biju <biju.das.au@gmail.com>
Patches: 3
Reviewed: 2026-05-25T16:56:33.740823
---
This is a 2-patch series adding support for the Renesas RZ/G3L LVDS encoder: a DT binding document (patch 1) and the driver itself (patch 2). The series is well-structured and follows patterns established by the existing `rzg2l_mipi_dsi.c` sibling driver. The code is generally clean and the binding document is complete.
However, there are several issues ranging from minor to moderate:
1. **Unused includes** in the driver (`of_device.h`, `of_graph.h`, several others).
2. **`rst` and `arst` reset controls are acquired but never stored** — they're asserted in probe and then lost, meaning they can never be deasserted on remove or error paths.
3. **`pm_runtime_get_sync` error path leaks the PM reference count** — on failure, `pm_runtime_put` is never called.
4. **Register header style inconsistency** — mixes `BIT()` macro with raw `(1 << n)` shifts.
5. **Cover letter says "v2->v3" but subject says "[PATCH v2]"** — version numbering is inconsistent.
The DT binding (patch 1) looks correct and already has an Acked-by from Conor Dooley.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 6:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-24 19:44 [PATCH v2 0/2] Add support for Renesas RZ/G3L LVDS encoder Biju
2026-05-24 19:44 ` [PATCH v2 1/2] dt-bindings: display: bridge: Document " Biju
2026-05-25 6:56 ` Claude review: " Claude Code Review Bot
2026-05-24 19:44 ` [PATCH v2 2/2] drm: renesas: rz-du: Add support for " Biju
2026-05-25 6:56 ` Claude review: " Claude Code Review Bot
2026-05-25 6:56 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-26 7:47 [PATCH v3 0/2] Add support for Renesas " Biju
2026-05-27 5:11 ` Claude review: " Claude Code Review Bot
2026-04-21 17:29 [PATCH v2 0/3] " Biju
2026-04-22 22:20 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260524194457.479681-1-biju.das.jz@bp.renesas.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox