From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: tegra: Enable DMA Support on Tegra194 QSPI
Date: Tue, 26 May 2026 07:40:38 +1000 [thread overview]
Message-ID: <review-overall-20260525-tegra194-qspi-iommu-v2-0-a11c53f804b2@gmail.com> (raw)
In-Reply-To: <20260525-tegra194-qspi-iommu-v2-0-a11c53f804b2@gmail.com>
Overall Series Review
Subject: arm64: tegra: Enable DMA Support on Tegra194 QSPI
Author: Aaron Kling via B4 Relay <devnull+webgeek1234.gmail.com@kernel.org>
Patches: 3
Reviewed: 2026-05-26T07:40:38.386949
---
This is a 2-patch series that enables DMA support for the QSPI controllers on Tegra194 (Jetson Xavier NX). The first patch fixes the SPI driver to pass the DMA engine's `struct device` to DMA API calls instead of the SPI controller's device, ensuring the correct IOMMU mappings are used. The second patch adds the `dmas`/`dma-names` properties to the Tegra194 QSPI device tree nodes.
The approach is correct and follows established patterns. `dmaengine_get_dma_device()` is the standard API for obtaining the right device pointer for DMA API calls when a DMA engine is involved, and several other drivers in the tree use it similarly. The series addresses a real functional problem (PIO timeouts, CBB faults) and the v2 changes address previous review feedback cleanly. The DT change follows existing conventions in the same file.
I have a couple of minor observations but nothing blocking.
**Verdict: Series looks good overall.**
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-25 21:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 6:47 [PATCH v2 0/2] arm64: tegra: Enable DMA Support on Tegra194 QSPI Aaron Kling via B4 Relay
2026-05-25 6:47 ` [PATCH v2 1/2] spi: tegra210-quad: Allocate DMA memory for DMA engine Aaron Kling via B4 Relay
2026-05-25 21:40 ` Claude review: " Claude Code Review Bot
2026-05-25 6:47 ` [PATCH v2 2/2] arm64: tegra: Enable DMA Support on Tegra194 QSPI Aaron Kling via B4 Relay
2026-05-25 21:40 ` Claude review: " Claude Code Review Bot
2026-05-25 21:40 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260525-tegra194-qspi-iommu-v2-0-a11c53f804b2@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox