From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/v3d: fix to avoid cleaning up uninitialized CPU jobs
Date: Tue, 26 May 2026 06:51:56 +1000 [thread overview]
Message-ID: <review-overall-20260525140422.1545327-1-aha310510@gmail.com> (raw)
In-Reply-To: <20260525140422.1545327-1-aha310510@gmail.com>
Overall Series Review
Subject: drm/v3d: fix to avoid cleaning up uninitialized CPU jobs
Author: Jeongjun Park <aha310510@gmail.com>
Patches: 1
Reviewed: 2026-05-26T06:51:56.642302
---
This is a single-patch fix for a real bug: `v3d_submit_cpu_ioctl` calls `v3d_job_cleanup()` on a CPU job that was never initialized with `v3d_job_init()`, causing undefined behavior via `drm_sched_job_cleanup()` on uninitialized scheduler state. The bug diagnosis is correct and the general approach — move `v3d_job_init()` earlier and add a separate error path for pre-init failures — is the right direction.
However, the patch has two compile-blocking problems and a memory leak, and appears to be based on an older tree (it does not include the `kvfree` query cleanup lines present on drm-next). As submitted, this patch will not build.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-25 20:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 14:04 [PATCH] drm/v3d: fix to avoid cleaning up uninitialized CPU jobs Jeongjun Park
2026-05-25 20:51 ` Claude review: " Claude Code Review Bot
2026-05-25 20:51 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260525140422.1545327-1-aha310510@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox