Claude review: drm: tyr: use lifetime-bound IoMem

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm: tyr: use lifetime-bound IoMem
Author: Danilo Krummrich <dakr@kernel.org>
Patches: 7
Reviewed: 2026-05-27T15:26:02.455706

---

This is a clean 2-patch refactoring series from Danilo Krummrich that modernizes the tyr (Arm Mali Valhall) DRM driver to use the new driver-core lifetime infrastructure. The series depends on a prerequisite patch set [1] that adds lifetime-bound driver data to the platform driver framework, and is based on drm-rust-next (not the drm-next tree available here — hence the apply failure and the substantial differences in the register access pattern).

**Patch 1** separates the `platform::Driver` trait implementation onto a new zero-sized `TyrPlatformDriver` type, keeping `TyrPlatformDriverData` as the associated `Data<'bound>` type. This is a standard pattern enabling the new GAT-based lifetime-bound driver data.

**Patch 2** takes advantage of that lifetime binding to use `IoMem<'a>` directly on the stack in probe, removing the `Devres`/`Arc` wrapping that was previously needed to satisfy `'static` requirements. This simplifies register access by eliminating the `(*iomem).access(dev)?` indirection.

The overall direction is good — the I/O memory is only used during probe and never stored in driver data, so the `Devres` revocation machinery was unnecessary overhead. One minor issue noted below.

---
Generated by Claude Code Patch Reviewer