From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: drm: tyr: separate driver type from driver data
Date: Wed, 27 May 2026 15:26:02 +1000 [thread overview]
Message-ID: <review-patch1-20260525230152.277820-2-dakr@kernel.org> (raw)
In-Reply-To: <20260525230152.277820-2-dakr@kernel.org>
Patch Review
This patch introduces `TyrPlatformDriver` as a unit struct and moves the `platform::Driver` trait impl onto it, with `TyrPlatformDriverData` becoming the `type Data<'bound>` associated type.
The changes are straightforward and correct:
- **driver.rs**: New `pub(crate) struct TyrPlatformDriver;`, trait impl moved from `TyrPlatformDriverData` to `TyrPlatformDriver`, probe signature gains explicit `'bound` lifetime, return type changes from `impl PinInit<Self, Error>` to `impl PinInit<Self::Data<'bound>, Error>`.
- **tyr.rs**: `module_platform_driver!` updated to reference `TyrPlatformDriver`.
- **OF_TABLE**: Reference updated from `<TyrPlatformDriverData as platform::Driver>::IdInfo` to `<TyrPlatformDriver as platform::Driver>::IdInfo`.
No issues. This is a mechanical separation that follows the pattern required by the new framework.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-27 5:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 23:01 [PATCH 0/2] drm: tyr: use lifetime-bound IoMem Danilo Krummrich
2026-05-25 23:01 ` [PATCH 1/2] gpu: drm: tyr: separate driver type from driver data Danilo Krummrich
2026-05-26 1:17 ` Eliot Courtney
2026-05-26 6:43 ` Boris Brezillon
2026-05-27 5:26 ` Claude Code Review Bot [this message]
2026-05-25 23:01 ` [PATCH 2/2] gpu: drm: tyr: use IoMem directly instead of Devres Danilo Krummrich
2026-05-26 1:30 ` Alexandre Courbot
2026-05-26 2:43 ` Eliot Courtney
2026-05-27 5:26 ` Claude review: " Claude Code Review Bot
2026-05-27 5:26 ` Claude review: drm: tyr: use lifetime-bound IoMem Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260525230152.277820-2-dakr@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox