From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/i915/audio: skip ELD query for force-off connectors
Date: Wed, 27 May 2026 14:32:39 +1000 [thread overview]
Message-ID: <review-overall-20260526161925.17041-1-pmenzel@molgen.mpg.de> (raw)
In-Reply-To: <20260526161925.17041-1-pmenzel@molgen.mpg.de>
Overall Series Review
Subject: drm/i915/audio: skip ELD query for force-off connectors
Author: Paul Menzel <pmenzel@molgen.mpg.de>
Patches: 1
Reviewed: 2026-05-27T14:32:39.446168
---
This is a single patch that addresses a real annoyance: when a connector is forced off via `video=<connector>:d`, the HDA audio driver repeatedly calls `get_eld()` for that port, getting `-EINVAL` each time, which produces noisy debug logs. The fix adds a helper that checks if any connector on the port is forced off, and returns a clean "not connected" (`*enabled = false`, return 0) instead of an error.
The approach is reasonable and the commit message is well-written with clear before/after log evidence. However, there is a **locking concern** and a **semantic question** worth discussing.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-27 4:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 16:19 [PATCH] drm/i915/audio: skip ELD query for force-off connectors Paul Menzel
2026-05-27 4:32 ` Claude review: " Claude Code Review Bot
2026-05-27 4:32 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260526161925.17041-1-pmenzel@molgen.mpg.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox