From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/amdxdna: add AIE coredump support
Date: Wed, 27 May 2026 14:28:07 +1000 [thread overview]
Message-ID: <review-overall-20260526172943.1776017-1-lizhi.hou@amd.com> (raw)
In-Reply-To: <20260526172943.1776017-1-lizhi.hou@amd.com>
Overall Series Review
Subject: accel/amdxdna: add AIE coredump support
Author: Lizhi Hou <lizhi.hou@amd.com>
Patches: 1
Reviewed: 2026-05-27T14:28:07.674734
---
This is a single patch adding AIE coredump support to the `accel/amdxdna` driver, allowing per-context tile memory snapshots for post-mortem hardware debugging. The patch mixes two distinct changes: (1) refactoring the `amdxdna_alloc_msg_buffer`/`amdxdna_free_msg_buffer` API to use an opaque handle (`amdxdna_msg_buf_hdl`), and (2) adding the coredump ioctl and firmware message plumbing. These should arguably be separate patches for easier review and bisection.
The overall design is reasonable: the coredump walks all clients and hardware contexts under `dev_lock` + SRCU protection, sends a firmware message, and copies results to userspace. The permission model (own-context or `CAP_SYS_ADMIN`) is appropriate.
There are several concerns, ranging from a potential bug in the zero-buffers edge case to UAPI documentation issues, detailed below.
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-27 4:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 17:29 [PATCH V1] accel/amdxdna: add AIE coredump support Lizhi Hou
2026-05-27 4:28 ` Claude review: " Claude Code Review Bot
2026-05-27 4:28 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260526172943.1776017-1-lizhi.hou@amd.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox