From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/amdxdna: Disable device buffer exporting
Date: Wed, 27 May 2026 14:20:13 +1000 [thread overview]
Message-ID: <review-overall-20260526185058.1780869-1-lizhi.hou@amd.com> (raw)
In-Reply-To: <20260526185058.1780869-1-lizhi.hou@amd.com>
Overall Series Review
Subject: accel/amdxdna: Disable device buffer exporting
Author: Lizhi Hou <lizhi.hou@amd.com>
Patches: 1
Reviewed: 2026-05-27T14:20:13.447868
---
This is a single-patch submission that explicitly disables DMA-BUF exporting for device buffer objects in the amdxdna accelerator driver. The change is small, correct, and straightforward. By setting the `.export` callback on `amdxdna_gem_dev_obj_funcs` to a function that returns `-EOPNOTSUPP`, it overrides the default fallback to `drm_gem_prime_export()` (seen in `drm_prime.c:387-390`), which would otherwise attempt to export a buffer that the driver never intends to share.
The approach is the standard DRM pattern for disabling export on specific GEM object types. No issues found.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-27 4:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 18:50 [PATCH V1] accel/amdxdna: Disable device buffer exporting Lizhi Hou
2026-05-27 4:20 ` Claude review: " Claude Code Review Bot
2026-05-27 4:20 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260526185058.1780869-1-lizhi.hou@amd.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox