public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/amdxdna: Disable device buffer exporting
Date: Wed, 27 May 2026 14:20:13 +1000	[thread overview]
Message-ID: <review-patch1-20260526185058.1780869-1-lizhi.hou@amd.com> (raw)
In-Reply-To: <20260526185058.1780869-1-lizhi.hou@amd.com>

Patch Review

**Status: Looks good**

The patch adds a minimal `.export` callback that returns `-EOPNOTSUPP` and wires it into `amdxdna_gem_dev_obj_funcs`:

```c
static struct dma_buf *amdxdna_gem_dev_obj_export(struct drm_gem_object *gobj, int flags)
{
	return ERR_PTR(-EOPNOTSUPP);
}
```

**Observations:**

1. **Correct error code**: `-EOPNOTSUPP` is appropriate here — it signals that the operation is not supported, which is the right semantic for a buffer type that should never be exported.

2. **Correct override mechanism**: Without this callback, `drm_gem_prime_handle_to_fd()` in `drm_prime.c:387-390` would fall through to `drm_gem_prime_export()`, which would attempt the export. The `dev_obj_funcs` struct lacks `.pin`, `.get_sg_table`, and other callbacks that the default export path relies on, so the export would likely fail in a confusing way or produce a non-functional dma-buf. Explicitly returning an error is much cleaner.

3. **Consistent with driver design**: The shmem object funcs (`amdxdna_gem_shmem_funcs` at line 739) have a custom `.export = amdxdna_gem_prime_export`, showing the driver is intentional about which object types can be exported. This patch completes that story for device objects.

4. **Unused parameter**: The `gobj` and `flags` parameters are unused, but this is standard for stub/rejection callbacks in the kernel — no `__maybe_unused` annotation is needed since the kernel build suppresses these warnings for function pointer implementations.

No concerns with this patch. It's a clean, minimal hardening fix.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-27  4:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26 18:50 [PATCH V1] accel/amdxdna: Disable device buffer exporting Lizhi Hou
2026-05-27  4:20 ` Claude Code Review Bot [this message]
2026-05-27  4:20 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260526185058.1780869-1-lizhi.hou@amd.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox