From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: Avoid using zero AC/DC brightness levels
Date: Thu, 28 May 2026 12:44:12 +1000 [thread overview]
Message-ID: <review-overall-20260526210048.1162477-1-edson.drosdeck@gmail.com> (raw)
In-Reply-To: <20260526210048.1162477-1-edson.drosdeck@gmail.com>
Overall Series Review
Subject: drm/amd/display: Avoid using zero AC/DC brightness levels
Author: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
Patches: 1
Reviewed: 2026-05-28T12:44:12.591232
---
This is a single-patch fix for a real-world issue where some systems report zero `ac_level`/`dc_level` values from ACPI firmware during backlight initialization. When these are zero, `DIV_ROUND_CLOSEST((max - min) * 0, 100)` yields zero brightness, which would set the panel to minimum brightness on boot — a bad user experience.
The fix is straightforward and correct: add guards to reject zero values and fall through to the `MAX_BACKLIGHT_LEVEL` fallback. The code change is minimal and low-risk.
**Minor concerns exist** around the commit message and a potential edge case with `max_brightness` not being set when the fallback fires, but overall this is a reasonable fix.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-28 2:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 21:00 [PATCH] drm/amd/display: Avoid using zero AC/DC brightness levels Edson Juliano Drosdeck
2026-05-28 2:44 ` Claude Code Review Bot [this message]
2026-05-28 2:44 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260526210048.1162477-1-edson.drosdeck@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox