From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: i915: selftests: fix oa_config refcount leak in test_stream()
Date: Thu, 28 May 2026 12:42:28 +1000 [thread overview]
Message-ID: <review-overall-20260527040835.854065-1-vulab@iscas.ac.cn> (raw)
In-Reply-To: <20260527040835.854065-1-vulab@iscas.ac.cn>
Overall Series Review
Subject: drm: i915: selftests: fix oa_config refcount leak in test_stream()
Author: Wentao Liang <vulab@iscas.ac.cn>
Patches: 1
Reviewed: 2026-05-28T12:42:28.615639
---
**NAK.** This single-patch series attempts to fix a refcount leak on the `!props.engine` error path in `test_stream()`, but the fix **introduces a NULL pointer dereference** that is strictly worse than the original leak. The patch moves the `!props.engine` check to *after* the line `gt = props.engine->gt;`, meaning if `props.engine` is NULL, the kernel will crash with a NULL dereference before it ever reaches the new guard.
The identified bug (leaking the `oa_config` reference when `props.engine` is NULL) is real, but the fix is incorrect.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-28 2:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 4:08 [PATCH] drm: i915: selftests: fix oa_config refcount leak in test_stream() Wentao Liang
2026-05-28 2:42 ` Claude Code Review Bot [this message]
2026-05-28 2:42 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260527040835.854065-1-vulab@iscas.ac.cn \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox