From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: xe: selftests: fix fence refcount leak in run_sanity_job()
Date: Thu, 28 May 2026 12:37:36 +1000 [thread overview]
Message-ID: <review-overall-20260527070244.858512-1-vulab@iscas.ac.cn> (raw)
In-Reply-To: <20260527070244.858512-1-vulab@iscas.ac.cn>
Overall Series Review
Subject: drm: xe: selftests: fix fence refcount leak in run_sanity_job()
Author: Wentao Liang <vulab@iscas.ac.cn>
Patches: 1
Reviewed: 2026-05-28T12:37:36.567576
---
This is a single-patch series claiming to fix a `dma_fence` refcount leak in `run_sanity_job()` in the xe driver's KUnit selftests. **The fix is correct and valid.** The function takes a reference via `dma_fence_get()` at line 55, then on the error path where `sanity_fence_failed()` returns true, the original code returned `-ETIMEDOUT` without calling `dma_fence_put()`, leaking the reference. The patch adds `dma_fence_put(fence)` before the early return, matching the `dma_fence_put(fence)` that already exists on the success path at line 63.
However, there are issues with the commit metadata.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-28 2:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 7:02 [PATCH] drm: xe: selftests: fix fence refcount leak in run_sanity_job() Wentao Liang
2026-05-28 2:37 ` Claude Code Review Bot [this message]
2026-05-28 2:37 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260527070244.858512-1-vulab@iscas.ac.cn \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox