Claude review: backlight: Add SY7758 6-channel High Efficiency LED Driver support

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: backlight: Add SY7758 6-channel High Efficiency LED Driver support
Author: Neil Armstrong <neil.armstrong@linaro.org>
Patches: 3
Reviewed: 2026-06-04T16:03:08.474195

---

This is a clean, well-structured 2-patch series adding support for the Silergy SY7758 6-channel LED backlight driver, used in the Ayaneo Pocket S2 handheld. The DT binding is minimal and follows existing patterns. The driver is compact and follows the established backlight driver idioms (ktz8866, aw99706). This is v5 with several rounds of review already incorporated.

There are a few concerns worth discussing:

1. **All hardware configuration is hardcoded** in `sy7758_init()`, making the driver specific to the Ayaneo Pocket S2 board rather than a generic SY7758 driver. A different board using this chip would need different current, PWM, and boost settings, but there's no DT property to configure them.
2. **Brightness=0 doesn't disable the LED channels** — the driver only writes zero to the brightness registers but never clears `BIT_CFG2_BL_ON`, so the chip stays powered even at minimum brightness.
3. Minor style nits (redundant masking, unused initialization).

None of these are blockers for a first version targeting a specific board, but items 1 and 2 are worth discussing.

---

---
Generated by Claude Code Patch Reviewer