From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/amdxdna: Return errors for failed debug BO commands
Date: Thu, 04 Jun 2026 16:14:42 +1000 [thread overview]
Message-ID: <review-overall-20260529162122.1976376-1-lizhi.hou@amd.com> (raw)
In-Reply-To: <20260529162122.1976376-1-lizhi.hou@amd.com>
Overall Series Review
Subject: accel/amdxdna: Return errors for failed debug BO commands
Author: Lizhi Hou <lizhi.hou@amd.com>
Patches: 2
Reviewed: 2026-06-04T16:14:42.300725
---
This is a single-patch bugfix for the `accel/amdxdna` driver. The patch fixes two related problems where debug BO (buffer object) config/sync commands could silently report success to userspace despite firmware failures:
1. The response handler `aie2_sched_drvcmd_resp_handler` returned success (ret=0) and left `result` at its zero-initialized value when `data` was NULL, making callers believe the command succeeded.
2. `aie2_hwctx_cfg_debug_bo` never set `ret` to an error code when `cmd.result` indicated a firmware failure, so it returned 0 to userspace despite logging an error.
The fix is small, correct, and well-targeted. One minor observation below about the commit message scope.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 6:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 16:21 [PATCH V1] accel/amdxdna: Return errors for failed debug BO commands Lizhi Hou
2026-05-31 13:17 ` Mario Limonciello
2026-06-04 6:14 ` Claude Code Review Bot [this message]
2026-06-04 6:14 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260529162122.1976376-1-lizhi.hou@amd.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox