public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/v3d: Fix indirect CSD jobs with zeroed workgroups
Date: Thu, 04 Jun 2026 15:15:36 +1000	[thread overview]
Message-ID: <review-overall-20260530-v3d-fix-indirect-csd-v1-0-15533948663f@igalia.com> (raw)
In-Reply-To: <20260530-v3d-fix-indirect-csd-v1-0-15533948663f@igalia.com>

Overall Series Review

Subject: drm/v3d: Fix indirect CSD jobs with zeroed workgroups
Author: =?utf-8?q?Ma=C3=ADra_Canal?= <mcanal@igalia.com>
Patches: 4
Reviewed: 2026-06-04T15:15:36.533079

---

This is a clean, well-motivated two-patch series fixing real bugs in the V3D indirect CSD (Compute Shader Dispatch) path. Indirect CSD defers workgroup counts to a GPU buffer that may legitimately contain zeros at runtime. The series fixes two problems: (1) a vaddr mapping leak when the early-return path skips cleanup, and (2) submitting zero-count dispatches to hardware where the V3D block interprets 0 as 65536, causing invalid execution.

Both patches are small, well-targeted, and have appropriate `Cc: stable` and `Fixes:` tags. The series is correctly ordered — patch 1 fixes the leak in the CPU-side rewrite function, and patch 2 adds the guard in the hardware submission path.

One minor concern worth raising on patch 2, detailed below.

**Verdict: Series looks good. One minor style/consistency question on patch 2.**

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-06-04  5:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-30 19:51 [PATCH 0/2] drm/v3d: Fix indirect CSD jobs with zeroed workgroups Maíra Canal
2026-05-30 19:51 ` [PATCH 1/2] drm/v3d: Fix vaddr leak when indirect CSD has " Maíra Canal
2026-06-04  5:15   ` Claude review: " Claude Code Review Bot
2026-05-30 19:51 ` [PATCH 2/2] drm/v3d: Skip CSD when it " Maíra Canal
2026-06-01 10:11   ` Iago Toral
2026-06-04  5:15   ` Claude review: " Claude Code Review Bot
2026-06-04  5:15 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-06-01 19:13 [PATCH v2 0/2] drm/v3d: Fix indirect CSD jobs with " Maíra Canal
2026-06-04  3:44 ` Claude review: " Claude Code Review Bot
2026-06-02 11:57 [PATCH v3 0/2] " Maíra Canal
2026-06-04  2:49 ` Claude review: " Claude Code Review Bot
2026-06-02 17:50 [PATCH v4 0/2] " Maíra Canal
2026-06-04  2:23 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260530-v3d-fix-indirect-csd-v1-0-15533948663f@igalia.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox