public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/v3d: Fix indirect CSD jobs with zeroed workgroups
Date: Thu, 04 Jun 2026 12:23:39 +1000	[thread overview]
Message-ID: <review-overall-20260602-v3d-fix-indirect-csd-v4-0-654309e32bc0@igalia.com> (raw)
In-Reply-To: <20260602-v3d-fix-indirect-csd-v4-0-654309e32bc0@igalia.com>

Overall Series Review

Subject: drm/v3d: Fix indirect CSD jobs with zeroed workgroups
Author: =?utf-8?q?Ma=C3=ADra_Canal?= <mcanal@igalia.com>
Patches: 5
Reviewed: 2026-06-04T12:23:39.573582

---

This is a well-structured 2-patch bugfix series addressing two related issues with indirect CSD (Compute Shader Dispatch) on V3D when the GPU buffer contains zeroed workgroup counts. The series is authored by Maíra Canal at Igalia and is at v4, with Iago Toral's Reviewed-by on patch 1. Both patches target stable.

The problems are:
1. A vaddr leak from early-return without unmapping BOs.
2. Hardware misinterpretation of zero workgroup counts as 65536.

The fixes are clean, minimal, and correctly ordered — the leak fix comes first so it can be backported independently. The v4 revision improves on v3 by always writing CFG[0..2] from the indirect buffer before checking for zeros, which avoids leaving stale userspace values in the config registers. The series is tested against relevant CTS tests.

**Verdict: Series looks good.** One minor observation on patch 2 below (missing `active_job = NULL` for consistency), but it's not a correctness bug.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-06-04  2:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02 17:50 [PATCH v4 0/2] drm/v3d: Fix indirect CSD jobs with zeroed workgroups Maíra Canal
2026-06-02 17:50 ` [PATCH v4 1/2] drm/v3d: Fix vaddr leak when indirect CSD has " Maíra Canal
2026-06-04  2:23   ` Claude review: " Claude Code Review Bot
2026-06-02 17:50 ` [PATCH v4 2/2] drm/v3d: Skip CSD when it " Maíra Canal
2026-06-03  5:32   ` Iago Toral
2026-06-04  2:23   ` Claude review: " Claude Code Review Bot
2026-06-03 11:28 ` [PATCH v4 0/2] drm/v3d: Fix indirect CSD jobs with " Maíra Canal
2026-06-04  2:23 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-06-02 11:57 [PATCH v3 " Maíra Canal
2026-06-04  2:49 ` Claude review: " Claude Code Review Bot
2026-06-01 19:13 [PATCH v2 0/2] " Maíra Canal
2026-06-04  3:44 ` Claude review: " Claude Code Review Bot
2026-05-30 19:51 [PATCH 0/2] " Maíra Canal
2026-06-04  5:15 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260602-v3d-fix-indirect-csd-v4-0-654309e32bc0@igalia.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox