From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: buddy: remove stale @p parameter from gpu_buddy_print kernel-doc
Date: Thu, 04 Jun 2026 15:10:52 +1000 [thread overview]
Message-ID: <review-overall-20260530195736.5321-1-rosenp@gmail.com> (raw)
In-Reply-To: <20260530195736.5321-1-rosenp@gmail.com>
Overall Series Review
Subject: drm: buddy: remove stale @p parameter from gpu_buddy_print kernel-doc
Author: Rosen Penev <rosenp@gmail.com>
Patches: 1
Reviewed: 2026-06-04T15:10:52.966866
---
This is a single-patch series that fixes a trivial kernel-doc warning in `drivers/gpu/buddy.c`. The `gpu_buddy_print()` function takes only one parameter (`struct gpu_buddy *mm`), but the kernel-doc comment documented a second `@p` parameter that doesn't exist. The fix simply removes the stale `@p` line.
The patch is **correct and straightforward**. The function signature confirms there is no `@p` parameter — it was likely left behind when the function's signature was refactored (the `@p` name suggests it was once a `struct drm_printer *p` parameter, a common pattern in DRM subsystem print functions).
One minor observation: the commit message uses the tag `Assisted-by: Opencode:Big-pickle`, which is not a standard kernel tag. The recognized tag for AI-assisted contributions is currently under discussion in the kernel community, but this non-standard tag is the submitter's/maintainer's concern, not a code correctness issue.
**Recommendation:** Acceptable to merge as-is.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 5:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 19:57 [PATCH] drm: buddy: remove stale @p parameter from gpu_buddy_print kernel-doc Rosen Penev
2026-06-04 5:10 ` Claude Code Review Bot [this message]
2026-06-04 5:10 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260530195736.5321-1-rosenp@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox