From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: buddy: remove stale @p parameter from gpu_buddy_print kernel-doc
Date: Thu, 04 Jun 2026 15:10:53 +1000 [thread overview]
Message-ID: <review-patch1-20260530195736.5321-1-rosenp@gmail.com> (raw)
In-Reply-To: <20260530195736.5321-1-rosenp@gmail.com>
Patch Review
**Status: Looks good**
The change removes one line from the kernel-doc comment:
```c
/**
* gpu_buddy_print - print allocator state
*
* @mm: GPU buddy manager
- * @p: GPU printer to use
*/
void gpu_buddy_print(struct gpu_buddy *mm)
```
The function `gpu_buddy_print()` at line 1483 takes a single `struct gpu_buddy *mm` parameter. The `@p` documentation was stale — there is no second parameter. This would cause a kernel-doc warning (`Excess function parameter 'p' description`).
No concerns with this patch.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-06-04 5:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 19:57 [PATCH] drm: buddy: remove stale @p parameter from gpu_buddy_print kernel-doc Rosen Penev
2026-06-04 5:10 ` Claude review: " Claude Code Review Bot
2026-06-04 5:10 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260530195736.5321-1-rosenp@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox