Claude review: drm/msm/dp: add EDID re-read retry in msm_dp_panel_get_modes()

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/msm/dp: add EDID re-read retry in msm_dp_panel_get_modes()
Author: Jens Glathe via B4 Relay
 <devnull+jens.glathe.oldschoolsolutions.biz@kernel.org>
Patches: 5
Reviewed: 2026-06-04T14:42:15.755995

---

This is a single patch that adds EDID re-read retry logic to `msm_dp_panel_get_modes()` to handle the case where the initial EDID read (done in `msm_dp_panel_read_sink_caps()` during HPD) returns a structurally valid but content-deficient EDID that yields zero modes.

The problem being addressed is real — flaky USB-C/DP adapters can produce garbage EDIDs, and retrying the read is a reasonable workaround. However, the implementation has several significant issues with correctness, placement, and missing checks.

**Verdict: Needs rework.** The retry logic belongs in `msm_dp_panel_read_sink_caps()` where the EDID is originally read, not in `get_modes()`. The current patch also has bugs around the zero-modes-from-re-read path and introduces sleeping in a callback context that may not be appropriate.

---

---
Generated by Claude Code Patch Reviewer