From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/qxl: fix local_gobj leak in qxl_gem_object_create_with_handle
Date: Thu, 04 Jun 2026 14:38:32 +1000 [thread overview]
Message-ID: <review-overall-20260601064932.227375-1-lihongtao@kylinos.cn> (raw)
In-Reply-To: <20260601064932.227375-1-lihongtao@kylinos.cn>
Overall Series Review
Subject: drm/qxl: fix local_gobj leak in qxl_gem_object_create_with_handle
Author: Hongtao Lee <lihongtao@kylinos.cn>
Patches: 1
Reviewed: 2026-06-04T14:38:32.055574
---
This is a single-patch series that fixes a real GEM object reference leak in the QXL driver. The analysis is correct: when `qxl_gem_object_create()` succeeds, it returns a GEM object with a reference count. If the subsequent `drm_gem_handle_create()` call fails, the original code returned the error without dropping that reference, leaking the object.
The fix is straightforward, correct, and follows established kernel patterns for GEM object cleanup. It's a clear bug that has existed since the QXL driver was first introduced.
**Verdict: Good patch. Recommend applying.**
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-06-04 4:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 6:49 [PATCH] drm/qxl: fix local_gobj leak in qxl_gem_object_create_with_handle Hongtao Lee
2026-06-04 4:38 ` Claude review: " Claude Code Review Bot
2026-06-04 4:38 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260601064932.227375-1-lihongtao@kylinos.cn \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox