public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm/todo: clarify drm_syncobj error TODOs
@ 2026-06-01  8:51 Christian König
  2026-06-01  9:10 ` Tvrtko Ursulin
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Christian König @ 2026-06-01  8:51 UTC (permalink / raw)
  To: michel.daenzer, tvrtko.ursulin, dri-devel; +Cc: Christian König

Before I get another mail asking if somebody is already working on this
clarify that the kernel parts are already implemented and we only need
the userspace parts done.

Add Michel as additional contact since he wrote a really good summary
how that could potentially be used by compositors.

Signed-off-by: Christian König <christian.koenig@amd.com>
---
 Documentation/gpu/todo.rst | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index f5a6139356da..f85c4585750d 100644
--- a/Documentation/gpu/todo.rst
+++ b/Documentation/gpu/todo.rst
@@ -896,10 +896,11 @@ complection of submission.
 One minor feature still missing is a generic DRM IOCTL to query the error
 status of binary and timeline drm_syncobj.
 
-This should probably be improved by implementing the necessary kernel interface
-and adding support for that in the userspace stack.
+This was already improved by implementing the necessary kernel interface
+(patches are on the dri-devel mailing list ) but adding support for that in the
+userspace stack is still missing.
 
-Contact: Christian König
+Contact: Christian König, Michel Dänzer
 
 Level: Starter
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/todo: clarify drm_syncobj error TODOs
  2026-06-01  8:51 [PATCH] drm/todo: clarify drm_syncobj error TODOs Christian König
@ 2026-06-01  9:10 ` Tvrtko Ursulin
  2026-06-04  4:27 ` Claude review: " Claude Code Review Bot
  2026-06-04  4:27 ` Claude Code Review Bot
  2 siblings, 0 replies; 4+ messages in thread
From: Tvrtko Ursulin @ 2026-06-01  9:10 UTC (permalink / raw)
  To: Christian König, michel.daenzer, dri-devel; +Cc: Christian König


On 01/06/2026 09:51, Christian König wrote:
> Before I get another mail asking if somebody is already working on this
> clarify that the kernel parts are already implemented and we only need
> the userspace parts done.
> 
> Add Michel as additional contact since he wrote a really good summary
> how that could potentially be used by compositors.
> 
> Signed-off-by: Christian König <christian.koenig@amd.com>
> ---
>   Documentation/gpu/todo.rst | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index f5a6139356da..f85c4585750d 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -896,10 +896,11 @@ complection of submission.
>   One minor feature still missing is a generic DRM IOCTL to query the error
>   status of binary and timeline drm_syncobj.
>   
> -This should probably be improved by implementing the necessary kernel interface
> -and adding support for that in the userspace stack.
> +This was already improved by implementing the necessary kernel interface
> +(patches are on the dri-devel mailing list ) but adding support for that in the
> +userspace stack is still missing.
>   
> -Contact: Christian König
> +Contact: Christian König, Michel Dänzer
>   
>   Level: Starter
>   

Acked-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>

Might be worth adding a lore link to aid finding it in the future and 
fix the stray space while pushing.

Regards,

Tvrtko


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Claude review: drm/todo: clarify drm_syncobj error TODOs
  2026-06-01  8:51 [PATCH] drm/todo: clarify drm_syncobj error TODOs Christian König
  2026-06-01  9:10 ` Tvrtko Ursulin
@ 2026-06-04  4:27 ` Claude Code Review Bot
  2026-06-04  4:27 ` Claude Code Review Bot
  2 siblings, 0 replies; 4+ messages in thread
From: Claude Code Review Bot @ 2026-06-04  4:27 UTC (permalink / raw)
  To: dri-devel-reviews

Overall Series Review

Subject: drm/todo: clarify drm_syncobj error TODOs
Author: "=?UTF-8?q?Christian=20K=C3=B6nig?=" <ckoenig.leichtzumerken@gmail.com>
Patches: 2
Reviewed: 2026-06-04T14:27:35.074183

---

This is a single documentation-only patch updating `Documentation/gpu/todo.rst` to reflect the current status of drm_syncobj error querying. The kernel IOCTL implementation work has been done (patches posted to dri-devel), but the userspace stack still needs updating. The patch also adds Michel Dänzer as a contact since he wrote a summary about compositor usage.

**Verdict: Straightforward and correct.** One very minor nit below.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Claude review: drm/todo: clarify drm_syncobj error TODOs
  2026-06-01  8:51 [PATCH] drm/todo: clarify drm_syncobj error TODOs Christian König
  2026-06-01  9:10 ` Tvrtko Ursulin
  2026-06-04  4:27 ` Claude review: " Claude Code Review Bot
@ 2026-06-04  4:27 ` Claude Code Review Bot
  2 siblings, 0 replies; 4+ messages in thread
From: Claude Code Review Bot @ 2026-06-04  4:27 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

**Purpose:** Prevent repeated "is anybody working on this?" emails by clarifying that the kernel side is done and only userspace work remains. Also adds Michel Dänzer as a second contact.

**Review:**

The changes are sensible and clearly motivated by the commit message. Two minor observations:

1. **Trailing space before closing parenthesis:**
   ```
   +(patches are on the dri-devel mailing list ) but adding support for that in the
   ```
   There's a stray space before the `)` — `mailing list )` should be `mailing list)`. This is a cosmetic nit but worth fixing since it's a documentation file that humans will read.

2. **Pre-existing typo `complection`** (line 894 in current tree / line 110 context in the patch):
   ```
   complection of submission.
   ```
   This should be `completion`. It's not introduced by this patch — it's pre-existing — but since the patch is already touching this section, it would be a nice drive-by fix to correct it. Not a blocker.

3. **Vagueness about kernel patches:** The text says "patches are on the dri-devel mailing list" without a link or series identifier. It might be helpful to readers to include a Message-Id or link-to-lore reference so they can find the actual kernel patches, but this is optional.

4. **Level unchanged at "Starter":** Since the kernel work is done and only userspace remains, keeping this as "Starter" seems appropriate — userspace integration work is a reasonable entry point for new contributors.

**Overall: The patch is good to go with the trivial whitespace fix (`mailing list )` → `mailing list)`).**

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-06-04  4:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-01  8:51 [PATCH] drm/todo: clarify drm_syncobj error TODOs Christian König
2026-06-01  9:10 ` Tvrtko Ursulin
2026-06-04  4:27 ` Claude review: " Claude Code Review Bot
2026-06-04  4:27 ` Claude Code Review Bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox