From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: cdns-mhdp8546: Add suspend resume support to the bridge driver
Date: Thu, 04 Jun 2026 14:19:35 +1000 [thread overview]
Message-ID: <review-overall-20260601095041.3042950-1-a-kumar2@ti.com> (raw)
In-Reply-To: <20260601095041.3042950-1-a-kumar2@ti.com>
Overall Series Review
Subject: drm/bridge: cdns-mhdp8546: Add suspend resume support to the bridge driver
Author: Abhash Kumar Jha <a-kumar2@ti.com>
Patches: 1
Reviewed: 2026-06-04T14:19:35.342050
---
This is a v3 single patch adding system suspend/resume support to the Cadence MHDP8546 DisplayPort bridge driver. The approach uses a genpd notifier to track whether the power domain was actually powered off during suspend, which determines whether firmware needs to be fully reloaded (after power loss) or just reactivated (after an aborted suspend). The patch also adds `phy_power_on`/`phy_power_off` calls that were previously missing from probe/remove.
The general design is reasonable, but there are several issues ranging from a missing cleanup path (notifier removal) to clock management conflicts with `devm_clk_get_enabled`, a missing `hw_state` update on the resume error path, and inconsistent error handling compared to the existing remove code.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 4:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 9:50 [PATCH v3] drm/bridge: cdns-mhdp8546: Add suspend resume support to the bridge driver Abhash Kumar Jha
2026-06-04 4:19 ` Claude Code Review Bot [this message]
2026-06-04 4:19 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260601095041.3042950-1-a-kumar2@ti.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox