Claude review: drm/msm/dp: add missing drm_edid_connector_update() before add_modes on cached EDID

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/msm/dp: add missing drm_edid_connector_update() before add_modes on cached EDID
Author: Jens Glathe via B4 Relay
 <devnull+jens.glathe.oldschoolsolutions.biz@kernel.org>
Patches: 1
Reviewed: 2026-06-04T12:21:12.498053

---

This is a single-patch fix for a real regression introduced by commit 5bea90ad9743 ("drm/msm/dp: switch to struct drm_edid"). The analysis is correct: the `struct drm_edid` API requires `drm_edid_connector_update()` to be called before `drm_edid_connector_add_modes()`, as explicitly documented in the kernel (`drm_edid.c:7152`: "Must be called before calling drm_edid_connector_add_modes()"). The initial EDID read path (`msm_dp_panel_read_sink_caps` at line 281) already calls `drm_edid_connector_update()`, but when `msm_dp_panel_get_modes()` is called with a cached EDID (i.e., the EDID was read on an earlier call), the connector's internal state may not have the EDID associated — for instance, after a connector reset or if `get_modes` is called on a different connector lifecycle. The fix is minimal, correct, and well-motivated by the v2 cover letter analysis.

**Verdict: Looks good. Recommend merge.**

---
Generated by Claude Code Patch Reviewer