public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/dumb-buffers: Increase size limits to match current devices
Date: Thu, 04 Jun 2026 13:08:23 +1000	[thread overview]
Message-ID: <review-overall-20260602073027.192758-1-tzimmermann@suse.de> (raw)
In-Reply-To: <20260602073027.192758-1-tzimmermann@suse.de>

Overall Series Review

Subject: drm/dumb-buffers: Increase size limits to match current devices
Author: Thomas Zimmermann <tzimmermann@suse.de>
Patches: 4
Reviewed: 2026-06-04T13:08:23.071360

---

This is a single patch from Thomas Zimmermann that increases the hardcoded sanity limits for dumb buffer creation from 8192x8192 at 32bpp to 16384x16384 at 64bpp. It fixes commit `5ab62dd3687b` which introduced overly strict limits that broke CI and high-end devices (e.g., 64bpp formats like XRGB16161616F, and resolutions beyond 8K).

**The patch targets an older codebase.** On the current drm-next tree, the file has been significantly refactored — the hardcoded width/height/bpp limits this patch modifies have been entirely removed and replaced with proper overflow-safe arithmetic (`check_mul_overflow`, `DIV_ROUND_UP` with explicit `U32_MAX` bounds, and format-aware pitch calculation via `drm_mode_size_dumb()`). This explains why the patch does not apply cleanly.

This patch is likely intended for **stable backport** or an older branch where the refactoring hasn't landed yet. As a fix for the original limiting commit, the approach is reasonable.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-06-04  3:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02  7:30 [PATCH] drm/dumb-buffers: Increase size limits to match current devices Thomas Zimmermann
2026-06-02 10:37 ` Saarinen, Jani
2026-06-02 10:53   ` Jani Nikula
2026-06-02 11:23     ` Thomas Zimmermann
2026-06-04  3:08 ` Claude Code Review Bot [this message]
2026-06-04  3:08 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260602073027.192758-1-tzimmermann@suse.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox