Claude review: Rust bindings for gem shmem

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Rust bindings for gem shmem
Author: Lyude Paul <lyude@redhat.com>
Patches: 7
Reviewed: 2026-06-04T12:29:53.038433

---

This is v16 of the Rust GEM shmem bindings series from Lyude Paul, building on work originally from Asahi Lina and Daniel Almeida. The series adds DMA reservation locking helpers, vmap support, `SetOnce::reset()`, a `Default` fix for `ObjectConfig`, faux device bound-context support, and scatter-gather table integration. The code is well-structured with clear safety documentation and thoughtful RAII patterns.

The overall architecture is sound: `DmaResvGuard` for scoped locking, `VMap` for typed memory mappings with compile-time size validation, and `SGTableMap` wrapped in `Devres` to ensure revocation on driver unbind. The double-checked locking pattern for lazy SGT initialization is correct with proper acquire/release ordering.

Key concerns:
1. Patch 6 references `__drm_gem_shmem_free_sgt_locked`, which does not exist in the current drm-next tree. This likely depends on a C-side export that should be in drm-rust-next but should be verified.
2. The import restructuring in patch 6 (changing `device` from `crate::drm::device` to `crate::device`) changes the meaning of the `dev()` return type. This may be correct on the intended base tree (drm-rust-next, base-commit b78dab829) but warrants attention.
3. Minor style and safety-comment nits throughout.

---

---
Generated by Claude Code Patch Reviewer