From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: writeback: Document behaviour for framebuffer size mismatch
Date: Thu, 04 Jun 2026 12:17:50 +1000 [thread overview]
Message-ID: <review-overall-20260602191754.79047-1-derek.foreman@collabora.com> (raw)
In-Reply-To: <20260602191754.79047-1-derek.foreman@collabora.com>
Overall Series Review
Subject: drm: writeback: Document behaviour for framebuffer size mismatch
Author: Derek Foreman <derek.foreman@collabora.com>
Patches: 1
Reviewed: 2026-06-04T12:17:50.607491
---
This is a single documentation-only patch (v2) to the DRM writeback connector subsystem. It adds six lines of kernel-doc commentary to the `WRITEBACK_FB_ID` property documentation in `drm_writeback.c`, specifying what should happen when the writeback framebuffer dimensions differ from the attached CRTC dimensions.
The patch is well-motivated: the existing documentation left this behavior entirely undefined, which is a problem for both driver implementers and userspace (compositors like Weston). The chosen policy — allow scaling, forbid cropping, and require failure over partial fills — is reasonable and pragmatic:
- **Scaling** is the natural operation for hardware with scaler blocks in the writeback path.
- **Cropping** is correctly excluded since there's no property to specify a crop origin.
- **Failure over partial fill** is the safe default, preventing garbage data in the output buffer.
The v2 change (making it explicit that partial fills must not occur) is a good improvement.
No functional code changes, no risk of regressions. This is straightforward UAPI documentation clarification.
**Verdict: Looks good.** Minor wording nit below, but nothing blocking.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 2:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 19:17 [PATCH v2] drm: writeback: Document behaviour for framebuffer size mismatch Derek Foreman
2026-06-04 2:17 ` Claude review: " Claude Code Review Bot
2026-06-04 2:17 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-06-01 19:57 [PATCH] " Derek Foreman
2026-06-04 3:41 ` Claude review: " Claude Code Review Bot
2026-06-04 3:41 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260602191754.79047-1-derek.foreman@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox