From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: writeback: Document behaviour for framebuffer size mismatch
Date: Thu, 04 Jun 2026 12:17:50 +1000 [thread overview]
Message-ID: <review-patch1-20260602191754.79047-1-derek.foreman@collabora.com> (raw)
In-Reply-To: <20260602191754.79047-1-derek.foreman@collabora.com>
Patch Review
**Correctness:** The documentation accurately captures a sensible policy. It properly handles the three possible outcomes for size mismatch: scale (allowed), crop (disallowed), fail (always available as fallback). The "must fail instead of partially filling" language is a good addition in v2.
**Wording nit:** The phrase "an odd width for a sub-sampled format" at line 65:
```
+ * such as hardware scaler constraints or an odd width for a sub-sampled
+ * format, the writeback must fail instead of partially filling the buffer.
```
This example is reasonable but slightly tangential — odd-width-with-subsampling is more of a general format constraint issue than something specific to the scaling-vs-mismatch scenario being documented. It's fine as-is since it illustrates "unable to exactly fill," but a reviewer could argue it muddies the focus. Not worth blocking on.
**Integration with existing text:** The new text slots in cleanly between the description of what `WRITEBACK_FB_ID` stores and the instruction that "Userspace must set this property to an output buffer every time...". The flow reads naturally.
**Missing consideration:** The patch doesn't mention whether aspect ratio must be preserved during scaling, or whether arbitrary stretching is permitted. This is presumably left to the driver, which seems fine for now — adding aspect ratio constraints could come in a follow-up if needed.
**Reviewed-by: Looks good to merge.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 2:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 19:17 [PATCH v2] drm: writeback: Document behaviour for framebuffer size mismatch Derek Foreman
2026-06-04 2:17 ` Claude Code Review Bot [this message]
2026-06-04 2:17 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-06-01 19:57 [PATCH] " Derek Foreman
2026-06-04 3:41 ` Claude review: " Claude Code Review Bot
2026-06-04 3:41 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260602191754.79047-1-derek.foreman@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox