Claude review: drm/tyr: move probe resources into registration data

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/tyr: move probe resources into registration data
Author: Deborah Brouwer <deborah.brouwer@collabora.com>
Patches: 1
Reviewed: 2026-06-04T11:21:43.367133

---

This is a single well-structured patch that moves probe-time resources (platform device, clocks, regulators, MMIO mapping, firmware state, GPU info) out of `TyrDrmDeviceData` and into a new `TyrDrmRegistrationData<'bound>` struct tied to the DRM registration lifetime. It builds on top of Danilo Krummrich's drm-lifetime series, which introduces `Registration::new_with_lt()` and the `RegistrationData` associated type on `drm::Driver`.

The patch correctly establishes lifetime and ownership patterns for resources that firmware loading and GPU VM setup will need. The `Firmware` and `Mmu` stubs are minimal and appropriate for scaffolding future work.

**Strengths:**
- Clean separation between DRM device data (now empty) and registration-scoped resources
- Correct use of the `ForLt` higher-kinded type pattern for lifetime-parameterized registration data
- Reasonable safety argument for `new_with_lt`
- Stub modules are clearly documented as placeholders

**Concerns (minor to moderate):**
- The `Mmu` object is created, logs information, and is immediately dropped — it's not stored anywhere
- `pr_info!` in `mmu.rs` should use `dev_info!` with a device reference
- Missing `PinnedDrop` for `TyrDrmRegistrationData` to handle clock cleanup (depends on whether the base series changed `Clk` to auto-disable on drop)

---

---
Generated by Claude Code Patch Reviewer