From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/v3d: Scheduler and submission fixes and refactoring
Date: Thu, 04 Jun 2026 11:24:38 +1000 [thread overview]
Message-ID: <review-overall-20260603-v3d-sched-misc-fixes-v3-0-d7114bba55a0@igalia.com> (raw)
In-Reply-To: <20260603-v3d-sched-misc-fixes-v3-0-d7114bba55a0@igalia.com>
Overall Series Review
Subject: drm/v3d: Scheduler and submission fixes and refactoring
Author: =?utf-8?q?Ma=C3=ADra_Canal?= <mcanal@igalia.com>
Patches: 15
Reviewed: 2026-06-04T11:24:38.873719
---
This is a well-structured 14-patch series from Maira Canal that addresses scheduler and submission issues in the V3D driver. The series progresses logically from small cleanups/fixes (patches 1-6) through a DRM exec migration (patch 7), into a major refactoring of the submission code around a new `struct v3d_submit` abstraction (patches 8-12), adding out_sync validation (patch 13), and finally ensuring atomic submissions (patch 14).
The overall approach is sound. The `struct v3d_submit` abstraction is a clear improvement that unifies the previously ad-hoc per-ioctl submission patterns. The incremental decomposition makes the refactoring reviewable despite its scope.
There is one correctness issue (missing bounds check in `v3d_submit_add_job`), a few minor items, and the series is otherwise in good shape. Several patches already carry Reviewed-by tags from Tvrtko Ursulin and Iago Toral.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 1:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 22:25 [PATCH v3 00/14] drm/v3d: Scheduler and submission fixes and refactoring Maíra Canal
2026-06-03 22:25 ` [PATCH v3 01/14] drm/v3d: Drop unused drm_encoder.h include from v3d_drv.h Maíra Canal
2026-06-04 1:24 ` Claude review: " Claude Code Review Bot
2026-06-03 22:25 ` [PATCH v3 02/14] drm/v3d: Clear queue->active_job when v3d_fence_create() fails Maíra Canal
2026-06-04 1:24 ` Claude review: " Claude Code Review Bot
2026-06-03 22:25 ` [PATCH v3 03/14] drm/v3d: Use inline lock for dma fence initialization Maíra Canal
2026-06-04 1:24 ` Claude review: " Claude Code Review Bot
2026-06-03 22:25 ` [PATCH v3 04/14] drm/v3d: Replace spin_lock_irqsave() with spin_lock() Maíra Canal
2026-06-04 1:24 ` Claude review: " Claude Code Review Bot
2026-06-03 22:25 ` [PATCH v3 05/14] drm/v3d: Extract v3d_job_add_syncobjs() helper Maíra Canal
2026-06-04 1:24 ` Claude review: " Claude Code Review Bot
2026-06-03 22:25 ` [PATCH v3 06/14] drm/v3d: Reject invalid syncobj handles in submit ioctls Maíra Canal
2026-06-04 1:24 ` Claude review: " Claude Code Review Bot
2026-06-03 22:25 ` [PATCH v3 07/14] drm/v3d: Migrate BO reservation locking to DRM exec Maíra Canal
2026-06-04 1:24 ` Claude review: " Claude Code Review Bot
2026-06-03 22:25 ` [PATCH v3 08/14] drm/v3d: Introduce struct v3d_submit and convert CL/TFU/CSD ioctls Maíra Canal
2026-06-04 1:24 ` Claude review: " Claude Code Review Bot
2026-06-03 22:25 ` [PATCH v3 09/14] drm/v3d: Make v3d_get_cpu_indirect_csd_params() a pure parser Maíra Canal
2026-06-04 1:24 ` Claude review: " Claude Code Review Bot
2026-06-03 22:25 ` [PATCH v3 10/14] drm/v3d: Convert submit helpers to operate on struct v3d_submit Maíra Canal
2026-06-04 1:24 ` Claude review: " Claude Code Review Bot
2026-06-03 22:25 ` [PATCH v3 11/14] drm/v3d: Refactor CPU ioctl into unified submission chain Maíra Canal
2026-06-04 1:24 ` Claude review: " Claude Code Review Bot
2026-06-03 22:25 ` [PATCH v3 12/14] drm/v3d: Split BO fence attach from syncobj output handling Maíra Canal
2026-06-04 1:24 ` Claude review: " Claude Code Review Bot
2026-06-03 22:25 ` [PATCH v3 13/14] drm/v3d: Reject invalid out_sync handles in submit ioctls Maíra Canal
2026-06-04 1:24 ` Claude review: " Claude Code Review Bot
2026-06-03 22:25 ` [PATCH v3 14/14] drm/v3d: Ensure atomic submissions in v3d_submit_jobs() Maíra Canal
2026-06-04 1:24 ` Claude review: " Claude Code Review Bot
2026-06-04 1:24 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-10 22:11 [PATCH v2 00/14] drm/v3d: Scheduler and submission fixes and refactoring Maíra Canal
2026-05-16 5:59 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260603-v3d-sched-misc-fixes-v3-0-d7114bba55a0@igalia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox