Claude review: rust: drm: Higher-Ranked Lifetime private data

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: rust: drm: Higher-Ranked Lifetime private data
Author: Danilo Krummrich <dakr@kernel.org>
Patches: 13
Reviewed: 2026-06-04T12:03:16.472487

---

This is a well-designed 7-patch series from Danilo Krummrich that addresses a real soundness gap in the Rust DRM abstractions: ioctl handlers run in process context with no guarantee that the parent bus device is still bound. The series introduces:

1. **`ParentDevice` associated type** — type-level declaration of the bus device type
2. **`UnbindGuard`** — RAII guard wrapping `drm_dev_enter()`/`drm_dev_exit()` SRCU critical sections
3. **`RegistrationData`** — a `ForLt` associated type for data whose lifetime is tied to the binding scope, accessed safely through an HRTB closure
4. **Ioctl integration** — the dispatch macro wraps every handler in an UnbindGuard, automatically returning `ENODEV` on hot-unplug

The overall architecture is sound. The `drm_dev_unplug()` switch is correct — it sets `unplugged = true`, calls `synchronize_srcu()`, then `drm_dev_unregister()`, which guarantees that any `UnbindGuard` that successfully acquired the lock sees the device as bound, and `Registration::drop()` waits for all such critical sections to complete before dropping `reg_data`. The HRTB on `registration_data_with()` correctly prevents lifetime smuggling for invariant types.

A few concerns are noted below, mostly around safety documentation and a potential ordering subtlety.

---
Generated by Claude Code Patch Reviewer