From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: Fix mem_type change detection for async flips
Date: Fri, 05 Jun 2026 06:42:09 +1000 [thread overview]
Message-ID: <review-overall-20260604064424.3154796-1-matthew.schwartz@linux.dev> (raw)
In-Reply-To: <20260604064424.3154796-1-matthew.schwartz@linux.dev>
Overall Series Review
Subject: drm/amd/display: Fix mem_type change detection for async flips
Author: Matthew Schwartz <matthew.schwartz@linux.dev>
Patches: 2
Reviewed: 2026-06-05T06:42:09.444539
---
This is a single-patch fix for a clear and real bug in `amdgpu_dm_crtc_mem_type_changed()`. The analysis in the commit message is accurate: `drm_atomic_get_plane_state()` is a get-or-allocate function that returns the **new** state pointer (or allocates one if the plane isn't yet in the commit). Calling it twice for the same plane returns the same pointer both times, so the comparison `get_mem_type(old_plane_state->fb) != get_mem_type(new_plane_state->fb)` always evaluates to false, completely defeating the mem_type change detection.
The fix is correct, minimal, and well-explained. **Recommend merge.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 20:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 6:44 [PATCH] drm/amd/display: Fix mem_type change detection for async flips Matthew Schwartz
2026-06-04 9:49 ` Melissa Wen
2026-06-04 20:42 ` Claude Code Review Bot [this message]
2026-06-04 20:42 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260604064424.3154796-1-matthew.schwartz@linux.dev \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox