From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/virtgpu: Use ERR_PTR for fb_create callback error return
Date: Fri, 05 Jun 2026 06:40:48 +1000 [thread overview]
Message-ID: <review-overall-20260604071202.138235-1-liuqiangneo@163.com> (raw)
In-Reply-To: <20260604071202.138235-1-liuqiangneo@163.com>
Overall Series Review
Subject: drm/virtgpu: Use ERR_PTR for fb_create callback error return
Author: liuqiangneo@163.com
Patches: 1
Reviewed: 2026-06-05T06:40:48.679987
---
This is a single-patch series that fixes a real bug in the `virtio_gpu_user_framebuffer_create` function. The `fb_create` callback contract (documented in `drm_mode_config.h:78-81`) explicitly states it must return "a negative error code encoded with ERR_PTR()" on failure. However, one error path was returning `NULL` instead, which violates this contract and would cause the DRM core caller to misinterpret the error.
The fix is correct, minimal, and consistent with the other error paths in the same function, which all already use `ERR_PTR()`. This is a clear bug fix — **recommend accepting**.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 20:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 7:11 [PATCH] drm/virtgpu: Use ERR_PTR for fb_create callback error return liuqiangneo
2026-06-04 20:40 ` Claude Code Review Bot [this message]
2026-06-04 20:40 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260604071202.138235-1-liuqiangneo@163.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox