From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/mgag200: reject pixel clocks outside PLL range
Date: Mon, 18 May 2026 16:11:33 +1000 [thread overview]
Message-ID: <review-overall-28e476e896dafdd31518dc5360ab7766@berkoc.com> (raw)
In-Reply-To: <28e476e896dafdd31518dc5360ab7766@berkoc.com>
Overall Series Review
Subject: drm/mgag200: reject pixel clocks outside PLL range
Author: Berkant Koc <me@berkoc.com>
Patches: 1
Reviewed: 2026-05-18T16:11:33.330911
---
This is a single patch that adds a `permitteddelta` sanity check to six mgag200 PLL compute helpers (g200wb, g200eh, g200er, g200ev, g200eh3, g200ew3), matching what g200se already has. The problem is real: without the check, when no PLL register combination matches the requested pixel clock, `m`, `n`, `p`, `s` remain at zero, and `atomic_update` programs garbage into the PIXPLLC registers.
The fix is correct and mechanically consistent with the g200se reference. The `Fixes:` tag and `Cc: stable` are appropriate. One style concern worth raising, and one minor functional observation.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-18 6:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-17 13:03 [PATCH] drm/mgag200: reject pixel clocks outside PLL range Berkant Koc
2026-05-18 6:11 ` Claude review: " Claude Code Review Bot
2026-05-18 6:11 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-28e476e896dafdd31518dc5360ab7766@berkoc.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox