From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fbdev: atyfb: Remove unused fb_list
Date: Tue, 31 Mar 2026 17:25:36 +1000 [thread overview]
Message-ID: <review-overall-571a3e072a2eef5a587d768d74559fc549b03ab6.1774863796.git.geert@linux-m68k.org> (raw)
In-Reply-To: <571a3e072a2eef5a587d768d74559fc549b03ab6.1774863796.git.geert@linux-m68k.org>
Overall Series Review
Subject: fbdev: atyfb: Remove unused fb_list
Author: Geert Uytterhoeven <geert@linux-m68k.org>
Patches: 1
Reviewed: 2026-03-31T17:25:36.507096
---
This is a single, trivial cleanup patch that removes a dead variable (`fb_list`) from the ATY framebuffer driver. The change is correct and well-motivated — the variable is set but never read, as confirmed by a clang W=1 warning. The commit message provides good historical context (last user removed in 2004, linked list removed in 2002).
**Verdict: Looks good. No issues found.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-31 7:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 9:44 [PATCH] fbdev: atyfb: Remove unused fb_list Geert Uytterhoeven
2026-03-31 7:25 ` Claude Code Review Bot [this message]
2026-03-31 7:25 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-571a3e072a2eef5a587d768d74559fc549b03ab6.1774863796.git.geert@linux-m68k.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox