public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fbdev: atyfb: Remove unused fb_list
Date: Tue, 31 Mar 2026 17:25:36 +1000	[thread overview]
Message-ID: <review-patch1-571a3e072a2eef5a587d768d74559fc549b03ab6.1774863796.git.geert@linux-m68k.org> (raw)
In-Reply-To: <571a3e072a2eef5a587d768d74559fc549b03ab6.1774863796.git.geert@linux-m68k.org>

Patch Review

**Status: Clean**

The patch removes two things:

1. The static variable declaration:
```c
-static struct fb_info *fb_list = NULL;
```

2. The assignment in `aty_init()`:
```c
-	fb_list = info;
```

Both removals are straightforward dead code elimination. The variable was only ever assigned to, never read from, which is exactly what the clang warning reports. No other references to `fb_list` exist in this file (the diff removes all of them), so there's no risk of breaking anything.

The commit message properly credits the kernel test robot report and includes the `Closes:` tag linking to the build warning.

**Reviewed-by worthy.** No concerns.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-03-31  7:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-30  9:44 [PATCH] fbdev: atyfb: Remove unused fb_list Geert Uytterhoeven
2026-03-31  7:25 ` Claude review: " Claude Code Review Bot
2026-03-31  7:25 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-571a3e072a2eef5a587d768d74559fc549b03ab6.1774863796.git.geert@linux-m68k.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox